Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Make update from hosted catalog lazy #3802

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

Previously, if the catalog is outdated for a cloud, SkyPilot will try to pull from the catalog repo for the latest catalog, no matter whether that catalog is required or not. We now change it to lazy update instead, i.e., it will only update the catalog if it is necessary to read the catalog for that cloud.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo August 1, 2024 17:32
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! It will be helpful :)) LGTM!

@Michaelvll Michaelvll enabled auto-merge August 6, 2024 21:21
@Michaelvll Michaelvll added this pull request to the merge queue Aug 6, 2024
Merged via the queue into master with commit f921f13 Aug 6, 2024
20 checks passed
@Michaelvll Michaelvll deleted the lazy-update branch August 6, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants